Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3674] - Fix third party deposits text field contextual menu #1124

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

sergiupuhalschi-rdx
Copy link
Contributor

@sergiupuhalschi-rdx sergiupuhalschi-rdx commented Aug 5, 2024

Jira Ticket

Description

Because the androidx.compose.material3.ModalBottomSheet is implemented as a pop-up, currently it's not possible for a TextField inside it to have a contextual menu displayed on long press. There are a few issues opened but with no resolution (example).

This is why I decided to switch back to the custom implementation of the bottom sheet, but also to enlarge the draggable area around the handle, this being the reason for switching from it to the androidx.compose.material3.ModalBottomSheet in the first place.

Additionally:

  • Cleaned up third party deposits labeled radio buttons: removed unused code and replaced RadioButton with RadixRadioButton
  • Fixed the gateways bottom sheet padding

How to test

  • Check that the bottom sheet looks and works as expected (also any text can be pasted when long pressing on the text field and there is something in the clipboard) in one of the following places: Add Gateway, Add specific depositor, Add specific asset
  • Check that the draggable area of the custom bottom sheet is large enough (the area at the top around the drag handle)

Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
22.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sergiupuhalschi-rdx sergiupuhalschi-rdx merged commit 77b3894 into main Aug 6, 2024
8 of 9 checks passed
@sergiupuhalschi-rdx sergiupuhalschi-rdx deleted the sp/ABW-3674-ui-fixes branch August 6, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants